Curvy Cruves #482
Draft
Curvy Cruves #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladik01-11
reviewed
Sep 21, 2024
|
Have you tested it? |
Yes, the current |
|
Tested, it seems to work just fine. |
Pirulax
commented
Sep 22, 2024
source/game_sa/Curves.cpp
Outdated
| @@ -74,58 +75,9 @@ void CCurves::CalcCurvePoint( | |||
| ) { | |||
| timeProgress = std::clamp(timeProgress, 0.f, 1.f); | |||
|
|
|||
| const auto [pos, speedScale] = [&]() -> std::tuple<CVector, float> { | |||
There was a problem hiding this comment.
so you just removed this code? You should just comment it out.
There was a problem hiding this comment.
you're absolutely right.
Pirulax
commented
Sep 24, 2024
Comment on lines
+137
to
+141
| const auto curveFactor = CalcSpeedVariationInBend(startPos, endPos, startDir, endDir); | ||
| const auto curvePoint = lerp(startPos, endPos, timeProgress); | ||
|
|
||
| outPos = curvePoint + (curveFactor * (endDir - startDir)); | ||
| outSpeed = lerp(startDir, endDir, timeProgress) / ((float)totalTimeMs / 1000.f); |
There was a problem hiding this comment.
tbh i'd just not hook it
this code can't possibly be 100% correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will have to test it.