This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
feat: diverse improvements of the network schemas #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gtema
commented
Mar 8, 2024
gtema
commented
- chore: sort struct fields alphabetically during render
- feat: add router.XXX_router_interface schemas
- feat: improve generator to omit "mut" for builder
- feat: add router.xxx_extraroutes schema
- feat: add router.XXX_external_gateway schema
- fix: improve path prefix for conntrack-helper group
- fix: slightly improve parameter naming in neutron spec
- feat: add docstrings in cli for top level body fields
Small changes to jsonschema or model cause reorder of struct fields and/or enum kinds. To further reduce amount of unrelated changes sort also all struct fields alphabetically.
implement schemas for {add,remove}_router_interface which has `oneOf:
required: [subnet_id], required: [port_id]` to indicate that only one
of both can be specified at a time. This had effect on multiple things
in the schema processing turning at the wrong corner (going under oneOf
handling).
With this change explicit tests for the `object` schema type parsing has
been implemented
when operation does not support parameters and body there is no sense in making request builder mutable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.