Stop dereferencing followed by reborrowing in match and if let

[MarijnS95]

This is the churn part of #1134, initially intended to remove derive(Copy) from enum Fundamental to fit a String in there. Those were just addressing the compiler errors, but there are a lot - and I mean a lot - more cases where objects are first dereferenced (copied) like match *self {} and then later re-(mutably)-borrowed with ref and ref mut in match arms. This is not necessary anymore (both the * and ref/ref mut are simply removed) and makes the code more pleasant to read.

OTOH doing it this way satisfies https://rust-lang.github.io/rust-clippy/master/#pattern_type_mismatch.... Curious to all your thoughts!

If this is okay I'll go ahead and finish the remainder of the offenders. Finished!

[sdroege]

I think this change is good, yes. It improves readability by removing some unnecessary noise.

[MarijnS95]

@sdroege Thanks! I think I covered all instances of unnecessarily dereferencing followed by reborrowing, this is now ready for review.

[sdroege]

Looks good to me, big improvement :)

Only please don't put & into patterns but instead use ref / ref mut.

[MarijnS95]

Only please don't put & into patterns but instead use ref / ref mut.

& is the inverse of ref/ref mut so that won't work ;)

[sdroege]

Yeah so do it the other way around and match *var in these cases. Having & in patterns is very ugly

[MarijnS95]

Yeah so do it the other way around and match *var in these cases. Having & in patterns is very ugly

Those are unfortunately exactly the cases I need to make #1134 work. But then we can add ref in there too and it should work. I don't find it particularly ugly though, but who am I to say :)

[sdroege]

I'm quite sure that even was a clippy lint at some point (or maybe it's disabled by default now). You ideally never want to have & in patterns but only use ref / ref mut and match in the other direction if needed.

[MarijnS95]

I'm quite sure that even was a clippy lint at some point (or maybe it's disabled by default now). You ideally never want to have & in patterns but only use ref / ref mut and match in the other direction if needed.

Not that I recall, I only know about https://rust-lang.github.io/rust-clippy/master/#pattern_type_mismatch. Changes have been reverted now :)