Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of taking an &str take into<GString> #1184

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JAicewizard
Copy link

This should be completely compatible with the old generated code, however I have not looked at all cases. Cases I did explicitly look at are:

  • &str parameters
  • Option<&str> parameters
  • function parameters that take &str still take &str

It would be ideal if there was some kind of &GStr, to avoid hacking around ref_mode like in this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant