Exclude tests folder and Gir.toml, versions.txt files #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option would be to use something like this: include = ["src/*", "build.rs", "Cargo.toml", "LICENSE", "COPYRIGHT"]but that probably is more error prone and would lead to more questions. |
|
Same questions as for gtk-rs/gtk-rs-core#1158 (review) |
|
I did not know packagers use the tests from crates.io and the other included files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to gtk-rs/gtk-rs-core#1158
The size of the crates can be reduced by excluding the
testsfolder and theGir.toml+versions.txtfiles from being published to crates.io. All crates that are generated by gir have the two files and most will have atestsfolder. They never have to get published to crates.io so gir can automatically generate that line for us. If for whatever reason they do need to be published, the entries can be removed from the list. The entry is never overwritten if it exists. There can also be anincludelist. If that is the case, noexcludeis added.While this in most cases will only save a few KB, the gtk, gstreamer and related crates do get a lot of downloads so I believe it is beneficial.
You can see which files will be included without publishing the crates by running cargo package --list.