Use gir-parser #1577
Draft
Use gir-parser #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Jun 10, 2024
| let parent = elem | ||
| .attr("parent") | ||
| .map(|s| self.find_or_stub_type(ns_id, s)); | ||
| let parent = elem.parent().map(|s| self.find_or_stub_type(ns_id, s)); | ||
| let typ = Type::Class(Class { |
There was a problem hiding this comment.
Instead of using custom types for these things, could we move over to just using directly the types provided by your parser?
There was a problem hiding this comment.
That would require a huge amount of changes to be done before doing the switch. I rather do that as a second step and my intention for now is to make the gir types wrappers of the ones from the types provided by the parser + TypeId + fields for overrides the type sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from the in-house gir files parsing to a separate crate I built. It uses quick-xml internally.
For now this is capable of generating almost all gtk bindings, most of the failures are arrays related.