Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Replace Continue with ControlFlow #1066

Merged
merged 1 commit into from
Jul 6, 2023
Merged

glib: Replace Continue with ControlFlow #1066

merged 1 commit into from
Jul 6, 2023

Conversation

bilelmoussaoui
Copy link
Member

Fixes #1063

@bilelmoussaoui bilelmoussaoui mentioned this pull request Mar 24, 2023
Closed
sdroege
sdroege approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you update all the repos (incl gtk3-rs and gstreamer-rs / gst-plugins-rs) and then we'll merge it?

sdroege
sdroege previously approved these changes Jul 6, 2023
View reviewed changes
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/glib-control-flow branch from ec31031 to 6f3b1fe Compare July 6, 2023 12:04
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/glib-control-flow branch from 6f3b1fe to cb22abe Compare July 6, 2023 12:06
@bilelmoussaoui bilelmoussaoui merged commit 72d3ff9 into master Jul 6, 2023
46 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/glib-control-flow branch July 6, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace glib::Continue with ControlFlow
2 participants
@bilelmoussaoui @sdroege