Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphene: fix alignment of graphene_simd4f_t on armhf and s390x #1105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on May 26, 2023

  1. graphene: fix alignment of graphene_simd4f_t on armhf and s390x

    On systems with the armhf ABI as used by Debian and Ubuntu (amdv7 + VFP,
    but without NEON), graphene falls back to the scalar definition of
    graphene_simd4f_t, which has the same alignment as its base type, float.
    
    On s390x, the underlying type is a generic float
    __attribute__((vector_size(16)). Surprinsingly, the s390x ABI does not
    mandate alignment bigger than 8 for the vector types.
    
    Without these patches, the layout tests fail on those architectures. The
    armhf case is notable because there are a fair number of Raspberry Pis
    out there that use that ABI, either because their SoC isn't 64-bit ready
    or just because they have low memory.
    
    Ideally, we could specifiy this in the Gir.toml file, but it doesn't
    seem like the tool is flexible enough to express this kind of nuances,
    schopin-pro committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8066791 View commit details
    Browse the repository at this point in the history