Make FileInfo bytestring methods use CStrings #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Jun 1, 2023
| [[object.function]] | ||
| name = "set_attribute_byte_string" | ||
| # use CStr | ||
| manual = true |
There was a problem hiding this comment.
Hm we can't do string_type = "c_string"... that only handles all the other options. I wonder how that got forgotten :)
|
Shouldn't this be |
|
See the comments from upstream, it seems "byte string" suggests this is not actually always a file path, even though in every case it currently is? |
|
Should it be just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more correct for the optional attributes that store a path, i.e.
trash::orig-path,thumbnail::path, etc.For all current cases this should actually be a
Path, but that should be handled upstream by a couple new methods: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3461