-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a std_once_cell feature #1113
Conversation
We lose the CI testing on the minimum supported version, rust 1.65. Are we sure we are ok with that? |
Why is the last test failing? |
The docs regen thing is unrelated to this |
.github/workflows/CI.yml
Outdated
@@ -18,7 +18,7 @@ jobs: | |||
- stable | |||
- beta | |||
- nightly | |||
- "1.65.0" | |||
- "1.70.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We lose the CI testing on the minimum supported version, rust 1.65. Are we sure we are ok with that?
No, this needs to be optional and the CI needs to be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI needs to be updated accordingly.
What do toy mean by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed in in the meantime from ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to disable this specific feature for the 1.65 CI run. It would be good to enable it for the others though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
275cd28
to
e7a0ab3
Compare
.github/workflows/CI.yml
Outdated
@@ -23,7 +23,7 @@ jobs: | |||
- { name: "cairo", features: "png,pdf,svg,ps,use_glib,v1_18,freetype,script,xcb,xlib,win32-surface", nightly: "--features 'png,pdf,svg,ps,use_glib,v1_18,freetype,script,xcb,xlib,win32-surface'", test_sys: true } | |||
- { name: "gdk-pixbuf", features: "v2_42", nightly: "--all-features", test_sys: true } | |||
- { name: "gio", features: "v2_74", nightly: "--all-features", test_sys: true } | |||
- { name: "glib", features: "v2_74", nightly: "--all-features", test_sys: true } | |||
- { name: "glib", features: "v2_74", nightly: "--features=v2_76,log,log_macros,compiletests", test_sys: true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well for nightly it's obviously fine to enable that feature. The way how it was before seemed good to me :) Sorry
I only didn't merge this yet because there was some CI failure and I had no time to look into that yet
That adds std::cell::OnceCell and std::sync::OnceLock support for the properties macro.
That adds std::cell::OnceCell and std::sync::OnceLock support for the properties macro.