Add support for ext_trait in properties macro #1149
Conversation
bilelmoussaoui
added
the
needs-backport
glib-macros/tests/properties.rs
Outdated
| use super::*; | ||
|
|
||
| #[derive(Properties, Default)] | ||
| #[properties(wrapper_type = super::Author, ext_trait = AuthorExt)] |
There was a problem hiding this comment.
It seems strange to me that this trait is defined and implemented by this macro. Usually you want to have more things in the Ext trait than just property setters/getters
There was a problem hiding this comment.
I think that is fine, as long as the trait is named something like AuthorPropertiesExt, so you can also have a similar trait for auto generated signals in the future for example.
There was a problem hiding this comment.
And that could also be a super-trait of the actual Ext trait. Maybe we should make that clearer in the docs?
There was a problem hiding this comment.
Now the trait defaults to MyTypePropertiesExt. I didn't specify anything about a possible super-trait MyTypeExt, because we don't have any macro to build that trait yet. The user can implement it as they wish.
bilelmoussaoui
added
backported
closes #1059. Currently the user must always specify the name of the ext_trait.
Note: the ext trait is inevitably defined in the same
impmodule where#[derive(Properties)]is called.Sadly this feature won't support adding other methods generated by a signal macro, because macros can't share data and the entire trait definition must happen in one macro.