-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disentangle docsrs and features #1154
Conversation
Now that the gir changes have landed, it would be great to also update & regenerate the sys crate. |
Are you asking me to do it and add it to the PR? I see that you approved it already, so I am not sure |
Yes, please Just make sure the update submodule commit is separate from the regeneration, as that would simplify backporting |
Actually, I will do that along with more changes |
@@ -84,19 +84,19 @@ pub use socket_msg_flags::SocketMsgFlags; | |||
mod subprocess; | |||
mod subprocess_launcher; | |||
mod threaded_socket_service; | |||
#[cfg(any(unix, docsrs))] | |||
#[cfg(unix)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually correct? This way we won't get docs for this unless building on a unix-y system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is correct yes, but i would refer to @GuillaumeGomez here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like a problem then. Previously we got platform-specific docs when building docs on any platform. There's quite a bit of compat hackery for that :)
Remaining cleanup from #1078