glib: Implement object class methods via a trait instead of directly … #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
force-pushed
the
object-class-ext
branch
from
9174713
to
39474cf
Compare
…on `Class<Object>` This makes them callable directly from more places and is more in sync with how such methods are implemented in other crates that can't directly implement methods on `Class<T>`.
sdroege
force-pushed
the
object-class-ext
branch
from
39474cf
to
6f16255
Compare
bilelmoussaoui
approved these changes
Oct 11, 2023
bilelmoussaoui
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on
Class<Object>This makes them callable directly from more places and is more in sync with how such methods are implemented in other crates that can't directly implement methods on
Class<T>.I wonder if this breaks something!