Implement ext trait on IsA<T>, don't generate overridden methods #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranfdev
force-pushed
the
ext_trait_subclass
branch
from
797ba7d
to
3d8520b
Compare
ranfdev
force-pushed
the
ext_trait_subclass
branch
from
3d8520b
to
dc6da06
Compare
bilelmoussaoui
approved these changes
Oct 21, 2023
bilelmoussaoui
added
the
needs-backport
sdroege
approved these changes
Oct 23, 2023
bilelmoussaoui
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it's impossible to use the generated ext trait on a subclass.
When a property is overridden, the getter and setter is not generated, because that property should be accessed through the parent interface/trait. What do you think about that?