Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19 backports #1433

Merged
merged 14 commits into from
Jun 17, 2024
Merged

0.19 backports #1433

merged 14 commits into from
Jun 17, 2024

Conversation

pbor
Copy link
Contributor

@pbor pbor commented Jun 17, 2024

No description provided.

@sdroege
Copy link
Member

sdroege commented Jun 17, 2024

Please also backport the other ones that are marked as such.

Paolo Borelli and others added 10 commits June 17, 2024 11:47
This should document some of them, except types that are defined with macros
See next commit
So that rustdoc-stripper can embed the docs
This is especially useful when used in conjunction with gettext.
E.g:

    ...
    .buttons([gettext("_Cancel"), &gettext("_OK")])
@pbor
Copy link
Contributor Author

pbor commented Jun 17, 2024

firs we need to backport clippy fixes to gir: gtk-rs/gir#1582

Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me once the CI has passed

@pbor pbor merged commit 917b362 into gtk-rs:0.19 Jun 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants