glib-macros: add test macro for async-glib-context tests #1521
+70
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiagioFesta
force-pushed
the
wip/bfesta/macro-test-async
branch
from
23961b5
to
f5ec53e
Compare
sdroege
reviewed
Sep 29, 2024
glib-macros/src/test.rs
Outdated
|
|
||
| item_fn.block = syn::parse2(quote::quote! { | ||
| { | ||
| let main_ctx = glib::MainContext::default(); |
There was a problem hiding this comment.
You probably want each test to run in their own main context. Otherwise running multiple tests in parallel will easily cause chaos.
BiagioFesta
force-pushed
the
wip/bfesta/macro-test-async
branch
from
f5ec53e
to
4579c85
Compare
BiagioFesta
force-pushed
the
wip/bfesta/macro-test-async
branch
from
4579c85
to
c9c9bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a procedural macro for async tests, wrapping them in
glib::MainContext.Not sure if it's useful for others, but I found myself needing this occasionally. Feel free to reject if it's not a good fit.