Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Add glib-macros / glib 0.20.3 dependency #1527

Merged
merged 1 commit into from
Oct 1, 2024
Merged

glib: Add glib-macros / glib 0.20.3 dependency #1527

merged 1 commit into from
Oct 1, 2024

Conversation

sdroege
Copy link
Member

@sdroege sdroege commented Oct 1, 2024

Fixes #1526

@sdroege
Copy link
Member Author

sdroege commented Oct 1, 2024

Unfortunately this can't be added to just the dependencies in glib/glib-macros: gtk-rs-core/glib/Cargo.toml: unused manifest key: dependencies.glib-macros.version

@sdroege sdroege mentioned this pull request Oct 1, 2024
Closed
@bilelmoussaoui
Copy link
Member

Unfortunately this can't be added to just the dependencies in glib/glib-macros: gtk-rs-core/glib/Cargo.toml: unused manifest key: dependencies.glib-macros.version

Well, the goal is to never set versions there anyways otherwise the usage of workspace dependencies would be useless as cargo tells in the error message.

@sdroege sdroege merged commit b2ddc74 into gtk-rs:0.20 Oct 1, 2024
46 of 48 checks passed
@sdroege sdroege deleted the 0.20-glib-0.20.3-dep branch October 1, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui bilelmoussaoui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdroege @bilelmoussaoui