Regenerate with latest gir-files #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/regen-gir-files
branch
from
86bc2c9
to
b3255cb
Compare
sdroege
reviewed
Oct 19, 2024
| fn startup_notify_id(&self, info: &impl IsA<AppInfo>, files: &[File]) -> Option<glib::GString> { | ||
| fn startup_notify_id( | ||
| &self, | ||
| info: Option<&impl IsA<AppInfo>>, |
There was a problem hiding this comment.
Breaking change but as we discussed we'd backport these now because of correctness
There was a problem hiding this comment.
Yep, it would be nice to backport it actually as it blocks some work we have in ashpd :)
sdroege
reviewed
Oct 19, 2024
| @@ -17313,7 +17321,21 @@ extern "C" { | |||
| pub fn g_unix_mount_is_system_internal(mount_entry: *mut GUnixMountEntry) -> gboolean; | |||
| pub fn g_unix_mount_points_changed_since(time: u64) -> gboolean; | |||
| pub fn g_unix_mount_points_get(time_read: *mut u64) -> *mut glib::GList; | |||
| #[cfg(feature = "v2_82")] | |||
| #[cfg_attr(docsrs, doc(cfg(feature = "v2_82")))] | |||
| pub fn g_unix_mount_points_get_from_file( | |||
There was a problem hiding this comment.
This needs to be conditional for non-Windows
There was a problem hiding this comment.
Hm we don't do that for any others so it probably doesn't matter after all
There was a problem hiding this comment.
Shouldn't those be in the gio-unix gi file nowadays anyway?
There was a problem hiding this comment.
I think that was not done for backwards compatibility reasons
sdroege
reviewed
Oct 19, 2024
| pub fn g_unix_mounts_changed_since(time: u64) -> gboolean; | ||
| pub fn g_unix_mounts_get(time_read: *mut u64) -> *mut glib::GList; | ||
| #[cfg(feature = "v2_82")] | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "v2_82")))] | ||
| pub fn g_unix_mounts_get_from_file( |
There was a problem hiding this comment.
This needs to be conditional for non-Windows
sdroege
reviewed
Oct 19, 2024
sdroege
added
the
needs-backport
sdroege
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.