Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gtk] Default to trust_return_value_nullability #71

Merged
merged 1 commit into from
Nov 22, 2020
Merged

[gtk] Default to trust_return_value_nullability #71

merged 1 commit into from
Nov 22, 2020

Conversation

sophie-h
Copy link
Contributor

@sophie-h sophie-h commented Nov 22, 2020

Can we do it this way round? Here, every Object marked with trust_return_value_nullability = false should be checked and fixed at some point.

#68

@sdroege
Copy link
Member

sdroege commented Nov 22, 2020

Makes it more obvious which ones still need to be taken care of, so I like it

@bilelmoussaoui
Copy link
Member

bilelmoussaoui commented Nov 22, 2020

Sounds good to me, but let's wait until the regen with 2018 edition is in first.

@bilelmoussaoui
Copy link
Member

The regen with 2018 edition is now, this can now be rebased. It seems that the bindings were not re-generated btw

@sophie-h
Copy link
Contributor Author

The point of this PR is that nothing in the bindings changes at all. It's just a change in how we use trust_return_value_nullability.

@bilelmoussaoui
Copy link
Member

Ah my bad. Didn't notice the global change of trust_return_value_nullability

@bilelmoussaoui bilelmoussaoui merged commit 11460b4 into gtk-rs:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants