gdk: trust nullability annotations #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
until we send a PR upstream
The texture::*_bytes functions are not nullable compared to the ones that download to a file, because the file might not be writeable for example
sdroege
reviewed
Jan 1, 2022
|
Looks generally correct otherwise |
5 tasks
|
Okay, I have dropped all the Once that merge request is merged, we can merge this one & drop the manual annotations here once we get a new gir file. |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/trust-nullability
branch
from
64b430b
to
4183fd4
Compare
|
The merge request got merged, I went ahead and done something similar for the constructors as well https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4315. This should be ready to be merged. |
BrainBlasted
added a commit
to BrainBlasted/ashpd
that referenced
this pull request
Jan 1, 2022
bilelmoussaoui
pushed a commit
to bilelmoussaoui/ashpd
that referenced
this pull request
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those were the ones that i noticed and needs fixes upstream