Make prnouncer work with the new inline threads #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant docs (which helped me verify the change): |
AshCorr
force-pushed
the
ash/new-inline-threads
branch
from
165c68c
to
2003169
Compare
|
This has been rolled into #24, so we'll release them both over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Google has started rolling out Inline threads to all spaces which currently breaks prnouncers ability to create threads.
This PR fixes prnouncers ability to create threads by adding a
messageReplyOptionparameter to the Google chat webhook request which requests a thread be made when prnouncer posts.How to test
Ran locally with
cargo run