Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Audio pages are not "dark"

Co-authored-by: Daniel Clifton <[email protected]>
  • Loading branch information
oliverabrahams and DanielCliftonGuardian authored Oct 21, 2024
1 parent 955ed4a commit a932d0c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions dotcom-rendering/src/palette.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3133,7 +3133,7 @@ const articleSectionTitleDark: PaletteFunction = () =>
const articleLinkTextLight: PaletteFunction = ({ display, design, theme }) => {

Check failure on line 3133 in dotcom-rendering/src/palette.ts

View workflow job for this annotation

GitHub Actions / lint / check

'display' is defined but never used
if (design === ArticleDesign.Analysis) return sourcePalette.news[300];
if (design === ArticleDesign.Audio) {
return articleLinkTextDark({ display, design, theme });
return sourcePalette.neutral[86];
}
switch (theme) {
case Pillar.Lifestyle:
Expand Down Expand Up @@ -3179,7 +3179,7 @@ const articleLinkBorderLight: PaletteFunction = ({
}) => {
if (theme === ArticleSpecial.Labs) return sourcePalette.neutral[60];
if (design === ArticleDesign.Audio) {
return articleLinkBorderDark({ display, design, theme });
return sourcePalette.neutral[46];
}
if (theme === ArticleSpecial.SpecialReport) {
return sourcePalette.specialReport[300];
Expand Down Expand Up @@ -3215,7 +3215,7 @@ const articleMetaLinesDark: PaletteFunction = ({ design }) => {

const articleLinkHoverLight: PaletteFunction = ({ display, design, theme }) => {

Check failure on line 3216 in dotcom-rendering/src/palette.ts

View workflow job for this annotation

GitHub Actions / lint / check

'display' is defined but never used
if (design === ArticleDesign.Audio) {
return articleLinkHoverDark({ display, design, theme });
return sourcePalette.neutral[86];
}
switch (design) {
case ArticleDesign.DeadBlog:
Expand Down Expand Up @@ -3294,7 +3294,7 @@ const articleLinkBorderHoverLight: PaletteFunction = ({
return sourcePalette.neutral[7];
}
if (design === ArticleDesign.Audio) {
return articleLinkBorderHoverDark({ display, design, theme });
return sourcePalette.neutral[86];
}
if (theme === ArticleSpecial.SpecialReport) {
return sourcePalette.specialReport[100];
Expand Down

0 comments on commit a932d0c

Please sign in to comment.