Skip to content

Commit

Permalink
Update types
Browse files Browse the repository at this point in the history
  • Loading branch information
abeddow91 committed Oct 22, 2024
1 parent 767c81b commit dc2db79
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion dotcom-rendering/src/components/YoutubeAtom/YoutubeAtom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type {
ImagePositionType,
ImageSizeType,
} from '../Card/components/ImageWrapper';
import { AspectRatio } from '../CardPicture';

Check failure on line 10 in dotcom-rendering/src/components/YoutubeAtom/YoutubeAtom.tsx

View workflow job for this annotation

GitHub Actions / lint / check

All imports in the declaration are only used as types. Use `import type`
import { MaintainAspectRatio } from '../MaintainAspectRatio';
import type { VideoCategory } from './YoutubeAtomOverlay';
import { YoutubeAtomOverlay } from './YoutubeAtomOverlay';
Expand Down Expand Up @@ -51,7 +52,7 @@ export type Props = {
imageSize: ImageSizeType;
imagePositionOnMobile: ImagePositionType;
renderingTarget: RenderingTarget;
aspectRatio?: string;
aspectRatio?: AspectRatio;
};

export const YoutubeAtom = ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type {
ImagePositionType,
ImageSizeType,
} from './Card/components/ImageWrapper';
import { AspectRatio } from './CardPicture';

Check failure on line 11 in dotcom-rendering/src/components/YoutubeBlockComponent.importable.tsx

View workflow job for this annotation

GitHub Actions / lint / check

All imports in the declaration are only used as types. Use `import type`
import { useConfig } from './ConfigContext';
import { ophanTrackerApps, ophanTrackerWeb } from './YoutubeAtom/eventEmitters';
import { YoutubeAtom } from './YoutubeAtom/YoutubeAtom';
Expand Down Expand Up @@ -40,7 +41,7 @@ type Props = {
imageSize?: ImageSizeType;
imagePositionOnMobile?: ImagePositionType;
enableAds: boolean;
aspectRatio?: string;
aspectRatio?: AspectRatio;
};

/**
Expand Down

0 comments on commit dc2db79

Please sign in to comment.