Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Datawrapper embed styling #12306

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Commits on Oct 3, 2024

  1. Add example styling on datawrapper graphics

    This is an example of the kind of role-independent styling I would like
    to do on datawrapper graphics, by matching on the URL of the interactive
    element.
    emdash-ie committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9f42a31 View commit details
    Browse the repository at this point in the history
  2. Add role-dependent styling

    This is an example of the kind of role-dependent styling I would like to
    make for datawrapper graphics.
    emdash-ie committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cbcae2d View commit details
    Browse the repository at this point in the history
  3. Readme: use relative link to docs

    Relative links work well locally in text editors and on github, whereas
    an absolute link like this can be mildly frustrating when following from
    a text editor.
    emdash-ie committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    da8dff5 View commit details
    Browse the repository at this point in the history
  4. Add 32px top margin to Datawrapper embeds

    This 32px margin collapses with the existing 16px paragraph spacing.
    What about breakpoints? (Should I be using spacing constants? Probably)
    emdash-ie committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8f2b617 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4ceab5b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8256c53 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Use palette colour for top border

    This palette colour both matches the hex colour I had manually used, and
    seems like the most appropriate “border” colour listed in the file.
    Hopefully it’s a good choice: I must remember to ask in the PR.
    
    Also, looking at this has reminded me that I should check how my styling
    looks in dark mode!
    emdash-ie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    256ae39 View commit details
    Browse the repository at this point in the history
  2. Add bottom border for some roles

    For roles which move the graphics across the border on the side, we’d
    like to add a bottom border to avoid the odd reappearance of the side
    border after the graphic.
    emdash-ie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    940653f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3798369 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    135132f View commit details
    Browse the repository at this point in the history
  5. Keep large margins for supporting on mobile

    These margins were too small: the request from the visuals team is that
    they be 32px.
    emdash-ie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    05bda76 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Add Datawrapper embed stories

    I’ve added a story with a Datawrapper embed for each role, to have an
    easy way to look at the styling.
    
    I’ve also tweaked the Wrapper used in the InteractiveBlockComponent
    stories to match that used in the Figure stories. Since the layouts are
    similar, I think this should be fine?
    emdash-ie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cd2f632 View commit details
    Browse the repository at this point in the history