-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Datawrapper embed styling #12306
base: main
Are you sure you want to change the base?
Commits on Oct 3, 2024
-
Add example styling on datawrapper graphics
This is an example of the kind of role-independent styling I would like to do on datawrapper graphics, by matching on the URL of the interactive element.
Configuration menu - View commit details
-
Copy full SHA for 9f42a31 - Browse repository at this point
Copy the full SHA 9f42a31View commit details -
This is an example of the kind of role-dependent styling I would like to make for datawrapper graphics.
Configuration menu - View commit details
-
Copy full SHA for cbcae2d - Browse repository at this point
Copy the full SHA cbcae2dView commit details -
Readme: use relative link to docs
Relative links work well locally in text editors and on github, whereas an absolute link like this can be mildly frustrating when following from a text editor.
Configuration menu - View commit details
-
Copy full SHA for da8dff5 - Browse repository at this point
Copy the full SHA da8dff5View commit details -
Add 32px top margin to Datawrapper embeds
This 32px margin collapses with the existing 16px paragraph spacing. What about breakpoints? (Should I be using spacing constants? Probably)
Configuration menu - View commit details
-
Copy full SHA for 8f2b617 - Browse repository at this point
Copy the full SHA 8f2b617View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ceab5b - Browse repository at this point
Copy the full SHA 4ceab5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8256c53 - Browse repository at this point
Copy the full SHA 8256c53View commit details
Commits on Oct 21, 2024
-
Use palette colour for top border
This palette colour both matches the hex colour I had manually used, and seems like the most appropriate “border” colour listed in the file. Hopefully it’s a good choice: I must remember to ask in the PR. Also, looking at this has reminded me that I should check how my styling looks in dark mode!
Configuration menu - View commit details
-
Copy full SHA for 256ae39 - Browse repository at this point
Copy the full SHA 256ae39View commit details -
Add bottom border for some roles
For roles which move the graphics across the border on the side, we’d like to add a bottom border to avoid the odd reappearance of the side border after the graphic.
Configuration menu - View commit details
-
Copy full SHA for 940653f - Browse repository at this point
Copy the full SHA 940653fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3798369 - Browse repository at this point
Copy the full SHA 3798369View commit details -
Configuration menu - View commit details
-
Copy full SHA for 135132f - Browse repository at this point
Copy the full SHA 135132fView commit details -
Keep large margins for supporting on mobile
These margins were too small: the request from the visuals team is that they be 32px.
Configuration menu - View commit details
-
Copy full SHA for 05bda76 - Browse repository at this point
Copy the full SHA 05bda76View commit details
Commits on Oct 22, 2024
-
I’ve added a story with a Datawrapper embed for each role, to have an easy way to look at the styling. I’ve also tweaked the Wrapper used in the InteractiveBlockComponent stories to match that used in the Figure stories. Since the layouts are similar, I think this should be fine?
Configuration menu - View commit details
-
Copy full SHA for cd2f632 - Browse repository at this point
Copy the full SHA cd2f632View commit details