Rework trail text visibility logic & show on all breakpoints in flexible/general #12584
+93
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
changed the title
github-actions
bot
removed
the
run_chromatic
|
Size Change: -56 B (-0.01%) Total Size: 901 kB
ℹ️ View Unchanged
|
cemms1
force-pushed
the
cemms1/rework-trailtext-visibility-logic
branch
from
cca4459
to
c570f18
Compare
github-actions
bot
removed
the
run_chromatic
cemms1
force-pushed
the
cemms1/rework-trailtext-visibility-logic
branch
from
c570f18
to
e74cc06
Compare
github-actions
bot
removed
the
run_chromatic
cemms1
requested review from
jamesmockett,
abeddow91 and
Georges-GNM
and removed request for
a team
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
reviewed
Oct 21, 2024
Comment on lines
+443
to
+456
| const hideTrailTextUntil = () => { | ||
| if (isFlexibleContainer) { | ||
| return undefined; | ||
| } else if ( | ||
| imageSize === 'large' && | ||
| imagePositionOnDesktop === 'right' && | ||
| media?.type !== 'avatar' | ||
| ) { | ||
| return 'desktop'; | ||
| } else { | ||
| return 'tablet'; | ||
| } | ||
| }; | ||
|
|
abeddow91
force-pushed
the
cemms1/rework-trailtext-visibility-logic
branch
from
e74cc06
to
dfd9a3b
Compare
abeddow91
approved these changes
Oct 22, 2024
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (created by @cemms1 and merged by @abeddow91 10 minutes and 56 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactors the trail text component so that:
divrather than nesting adivwithin adivHidecomponent to control visibility rather than applying css directly"hideUntil"to describe when the trail text should be hiddenhideTrailTextUntilhelper function to store this logicisFlexibleContainerto the logic as we want trail text to show on all breakpoints in flexible containers IF the image has been removed (in which casetrailTextis not provided as a prop toFrontCardat all, see Show trail text on standard cards inflexible/generalcontainers if the image has been removed #12570)Why?
Improving the component for easier use and better understanding
Addresses issue of trail text not appearing on mobile screen sizes on standard cards in flexible general containers
Part of this Trello ticket
Screenshots