US marketing card component - design updates #12590
Merged
+54
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
force-pushed
the
doml/usa-expandable-design-updates
branch
from
f75f02f
to
e9a6c68
Compare
|
Size Change: +109 B (+0.01%) Total Size: 901 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
This was referenced Oct 21, 2024
arelra
reviewed
Oct 21, 2024
| const paragraphStyles = css` | ||
| ${textSans15} | ||
| margin-right: ${space[4]}px; | ||
| z-index: 1; |
There was a problem hiding this comment.
Minor - could this use getZindex() ?
There was a problem hiding this comment.
It's a bit tricky. The component has a z-index of 8 as that is suitable for the other elements on the page. This z-index is so the text appears on top of the illustrations within the component. Given this is all within the component, I think it would add noise to getZIndex which controls the order of things at a page level.
arelra
approved these changes
Oct 21, 2024
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @domlander 8 minutes and 51 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12589
What does this change?
Minor updates to the design of the US marketing card component
left-colbreakpointWhy?
Requested from Design team.
Screenshots