Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Flags #1308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify Flags #1308

wants to merge 2 commits into from
+23 −22

Conversation

NovemberTang
Copy link
Contributor

@NovemberTang NovemberTang commented Oct 23, 2024 •
edited
Loading

What does this change?

Cleans up the index by evaluating flags inside the relevant functions

Why?

Too many nested ifs are a bit of a nightmare to read.

How has it been verified?

  • CI Passes
  • Tested on CODE

@NovemberTang NovemberTang changed the title Nt/simplify flags Simplify Flags Oct 23, 2024
@github-actions GitHub Actions
Copy link

Deploy build 6092 of deploy::service-catalogue to CODE

All deployment options

From guardian/actions-riff-raff.

@NovemberTang NovemberTang marked this pull request as ready for review October 23, 2024 20:53
@NovemberTang NovemberTang requested review from a team as code owners October 23, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NovemberTang