Skip to content

Commit

Permalink
chore(all): clean
Browse files Browse the repository at this point in the history
  • Loading branch information
guillaume-chervet committed Oct 23, 2024
1 parent 67c973b commit 460b018
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ on:
docker_registry:
required: true
type: string
docker_repository:
required: true
type: string
secrets:
DOCKER_USERNAME:
required: true
Expand Down Expand Up @@ -57,7 +60,7 @@ jobs:
file : ${{ inputs.image_file }}
build-args: ${{ inputs.image_build_args }}
push: true
tags: ${{ inputs.docker_registry }}/${{ inputs.image_name }}:latest,${{ inputs.docker_registry }}/${{ inputs.image_name }}:${{ inputs.image_version }}
tags: ${{ inputs.docker_registry }}/${{ inputs.docker_repository }}/${{ inputs.image_name }}:latest,${{ inputs.docker_registry }}/${{ inputs.docker_repository }}/${{ inputs.image_name }}:${{ inputs.image_version }}
labels: ${{ steps.meta.outputs.labels }}

- name: Build and push Docker image
Expand All @@ -68,6 +71,6 @@ jobs:
file : ${{ inputs.image_file }}
build-args: ${{ inputs.image_build_args }}
push: true
tags: ${{ inputs.docker_registry }}/${{ inputs.image_name }}:${{ inputs.image_version }}
tags: ${{ inputs.docker_registry }}/${{ inputs.docker_repository }}/${{ inputs.image_name }}:${{ inputs.image_version }}
labels: ${{ steps.meta.outputs.labels }}

7 changes: 5 additions & 2 deletions .github/workflows/docker_with_model.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ on:
docker_registry:
required: true
type: string
docker_repository:
required: true
type: string
secrets:
DOCKER_USERNAME:
required: true
Expand Down Expand Up @@ -126,7 +129,7 @@ jobs:
file : ${{ inputs.image_file }}
build-args: ${{ inputs.image_build_args }}
push: true
tags: ${{ inputs.docker_registry }}/${{ inputs.image_name }}:latest,${{ inputs.docker_registry }}/${{ inputs.image_name }}:${{ inputs.image_version }}
tags: ${{ inputs.docker_registry }}/${{ inputs.docker_repository }}/${{ inputs.image_name }}:latest,${{ inputs.docker_registry }}/${{ inputs.docker_repository }}/${{ inputs.image_name }}:${{ inputs.image_version }}
labels: ${{ steps.meta.outputs.labels }}

- name: Build and push Docker image
Expand All @@ -137,6 +140,6 @@ jobs:
file : ${{ inputs.image_file }}
build-args: ${{ inputs.image_build_args }}
push: true
tags: ${{ inputs.docker_registry }}/${{ inputs.image_name }}:${{ inputs.image_version }}
tags: ${{ inputs.docker_registry }}/${{ inputs.docker_repository }}/${{ inputs.image_name }}:${{ inputs.image_version }}
labels: ${{ steps.meta.outputs.labels }}

2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ jobs:
- name: Deploy container
run: |
# https://learn.microsoft.com/en-us/cli/azure/container?view=azure-cli-latest#az-container-create()
az container create --resource-group ${{ env.AZURE_RESOURCE_GROUP_NAME}} --name ${{ env.AZURE_WEBAPP_NAME }} --dns-name-label ${{ env.AZURE_WEBAPP_NAME }} --image ${{ env.DOCKER_REGISTRY }}/${{ env.DOCKER_REPOSITORY }}/${{ env.DOCKER_API_IMAGE_NAME }}:${{ needs.tags.outputs.new_version }} --ports 5000
az container create --resource-group ${{ env.AZURE_RESOURCE_GROUP_NAME}} --name ${{ env.AZURE_WEBAPP_NAME }} --dns-name-label ${{ env.AZURE_WEBAPP_NAME }} --image ${{ env.DOCKER_REGISTRY }}/${{ needs.train.outputs.DOCKER_REPOSITORY }}/${{ env.DOCKER_API_IMAGE_NAME }}:${{ needs.tags.outputs.new_version }} --ports 5000
integration_tests:
environment: MLOpsPython
runs-on: ubuntu-latest
Expand Down

0 comments on commit 460b018

Please sign in to comment.