Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 #41

Merged
merged 52 commits into from
Feb 14, 2024
Merged

1.5 #41

merged 52 commits into from
Feb 14, 2024

Conversation

guillp
Copy link
Owner

@guillp guillp commented Dec 29, 2023

a lot of cosmetics changes:

  • replace most linters by ruff
  • apply fixes for most ruff rules
  • turn static classes into @attrs.frozen
  • review docs and docstrings

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0542bbb) 98.63% compared to head (d0c24aa) 99.72%.

Files Patch % Lines
requests_oauth2client/authorization_request.py 99.20% 1 Missing ⚠️
requests_oauth2client/tokens.py 99.09% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   98.63%   99.72%   +1.09%     
==========================================
  Files          18       18              
  Lines        1319     1461     +142     
==========================================
+ Hits         1301     1457     +156     
+ Misses         18        4      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillp guillp merged commit b7e7aba into main Feb 14, 2024
7 of 8 checks passed
@guillp guillp deleted the 1.5 branch February 14, 2024 16:08
guillp added a commit that referenced this pull request Feb 14, 2024
a lot of cosmetics changes:

* replace most linters by ruff
* apply fixes for most ruff rules
* turn static classes into @attrs.frozen (including OAuth2Client, AuthorizationRequest, BearerToken, etc.)
* review docs and docstrings
* expose EncryptionAlgs, KeyManagementAlgs, SignatureAlgs from jwskate
* more test coverage

**Breaking Changes:**
- Setting a root url at `ApiClient` init time is now mandatory. `ApiClient` will never send requests outside this root
- Helpers for Auth0 and Ping are now refactored into classmethods instead of using inheritance
- use Ellipsis as sentinel object instead of a dedicated GENERATE object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants