Review changes

gulivarese · May 12, 2024 · 6cb82b0 · 6cb82b0
1 parent f1371aa
commit 6cb82b0
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 12 deletions.
diff --git a/include/dlaf/common/callable_object.h b/include/dlaf/common/callable_object.h
@@ -8,8 +8,6 @@
 // SPDX-License-Identifier: BSD-3-Clause
 //
 
-#include <utility>
-
 #pragma once
 
 /// @file
@@ -25,6 +23,9 @@
 /// The function name is wrapped in parentheses to disable ADL. It is assumed
 /// that all required overloads are found relative to the namespace where the
 /// macro is used.
+
+#include <utility>
+
 #define DLAF_MAKE_CALLABLE_OBJECT(fname)                                                    \
   constexpr struct fname##_t {                                                              \
     template <typename... Ts>                                                               \

diff --git a/include/dlaf/communication/sync/basic.h b/include/dlaf/communication/sync/basic.h
@@ -8,12 +8,12 @@
 // SPDX-License-Identifier: BSD-3-Clause
 //
 
-#include <utility>
-
 #pragma once
 
 /// @file
 
+#include <utility>
+
 #include <dlaf/common/data.h>
 #include <dlaf/communication/communicator.h>
 #include <dlaf/communication/error.h>

diff --git a/include/dlaf/eigensolver/gen_to_std/impl.h b/include/dlaf/eigensolver/gen_to_std/impl.h
@@ -8,11 +8,11 @@
 // SPDX-License-Identifier: BSD-3-Clause
 //
 
+#pragma once
+
 #include <cstddef>
 #include <utility>
 
-#pragma once
-
 #include <pika/execution.hpp>
 
 #include <dlaf/blas/tile.h>

diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h
@@ -8,13 +8,12 @@
 // SPDX-License-Identifier: BSD-3-Clause
 //
 
-#include <iomanip>
-#include <iostream>
-
 #pragma once
 
 /// @file
 
+#include <iomanip>
+#include <iostream>
 #include <string>
 
 #include <dlaf/common/index2d.h>

diff --git a/include/dlaf/multiplication/hermitian/impl.h b/include/dlaf/multiplication/hermitian/impl.h
@@ -8,11 +8,11 @@
 // SPDX-License-Identifier: BSD-3-Clause
 //
 
+#pragma once
+
 #include <cstddef>
 #include <utility>
 
-#pragma once
-
 #include <pika/execution.hpp>
 #include <pika/thread.hpp>
 

diff --git a/src/init.cpp b/src/init.cpp
@@ -190,7 +190,6 @@ void updateConfiguration(const pika::program_options::variables_map& vm, configu
   updateConfigurationValue(vm, cfg.umpire_device_memory_pool_initial_bytes,
                            "UMPIRE_DEVICE_MEMORY_POOL_INITIAL_BYTES",
                            "umpire-device-memory-pool-initial-bytes");
-  // TODO: Warn if disabled
   cfg.mpi_pool = (pika::resource::pool_exists("mpi")) ? "mpi" : "default";
 
   // Warn if not using MPI pool without --dlaf:no-mpi-pool