Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Only allow js variants for .gulp config files #261

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

phated
Copy link
Member

@phated phated commented Mar 17, 2024

This restricts the .gulp config files to just JS variants. Since we're likely going to support translations and theming via functions as per #260, we only want to support variants that can define the functions.

@sttk tagging you here for feedback but I'm going to get this merged so I can update #260

@phated phated requested a review from sttk March 17, 2024 22:39
@phated phated merged commit e5c7983 into master Mar 17, 2024
18 checks passed
@phated phated deleted the phated/js-variant-configs branch March 17, 2024 22:48
@github-actions github-actions bot mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant