Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process 2 consecutive lines at a time in each thread #651

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ianopolousfast
Copy link
Contributor

@ianopolousfast ianopolousfast commented Jan 29, 2024

Process two consecutive lines lines at time, use better hash.
Some extra jvm args, and don't return index from temperature parsing.

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
  • Execution time: 12.0s (2.5s faster on 4 core i7)
  • Execution time of reference implementation: 288s

@ianopolousfast ianopolousfast changed the title Opt/2 at a time Process 2 consecutive lines at a time in each thread Jan 30, 2024
Use a better hash function

Don't return index from temperature parsing
extra JVM args
@gunnarmorling
Copy link
Owner

00:04.886 now.

@gunnarmorling gunnarmorling merged commit 0c5c228 into gunnarmorling:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants