Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission for Smoofie #701

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Submission for Smoofie #701

merged 3 commits into from
Feb 1, 2024

Conversation

Smoofie
Copy link
Contributor

@Smoofie Smoofie commented Jan 31, 2024

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions: line 216
  • Execution time: 2.286s
  • Execution time of reference implementation: 1m 58.669s

@gunnarmorling
Copy link
Owner

This seg faults on 32 cores for the 10K key set test (see create_measurements_3.sh). Note that we're after the cut-off time, so you'll have two more changes you can make to this PR (see note at the top of the README). If it's not working or valid then, I'll have to close it unfortunately. Updates should be pushed quickly, so I can evaluate all the pending entries. Thx!

< #
< # A fatal error has been detected by the Java Runtime Environment:
< #
< #  SIGSEGV (0xb) at pc;0x00007fc654a1dad1
< pid;1855790
< tid;1855813
< #
< # JRE version: OpenJDK Runtime Environment (21.0.1+12) (build 21.0.1+12-29)
< # Java VM: OpenJDK 64-Bit Server VM (21.0.1+12-29
< mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
< # Problematic frame:
< # J 111 c1 sun.misc.Unsafe.getInt(J)I [email protected] (8 bytes) @ 0x00007fc654a1dad1 [0x00007fc654a1da20+0x00000000000000b1][thread 1855816 also had an error]
< #
< #
< Core dump will be written. Default location: Core dumps may be processed with ";usr;lib;systemd;systemd-coredump %P %u %g %s %t %c %h" (or dumping to ;home;build;projects;eval;1brc;core.1855790)
< #
< # An error report file with more information is saved as:
< # ;home;build;projects;eval;1brc;hs_err_pid1855790.log
< [thread 1855811 also had an error]
< [thread 1855812 also had an error]
< [thread 1855814 also had an error]
< [thread 1855822 also had an error]
< [thread 1855815 also had an error]
< [thread 1855817 also had an error]
< [thread 1855819 also had an error]
< [thread 1855826 also had an error]
< [thread 1855818 also had an error]
< [thread 1855835 also had an error]
< [thread 1855832 also had an error]
< [thread 1855828 also had an error]
< [thread 1855823 also had an error]
< [thread 1855825 also had an error]
< [thread 1855824 also had an error]
< [thread 1855834 also had an error]
< [thread 1855821 also had an error]
< [thread 1855833 also had an error]
< [thread 1855836 also had an error]
< [thread 1855840 also had an error]
< [thread 1855838 also had an error]
< [thread 1855830 also had an error]
< [thread 1855837 also had an error]
< [thread 1855831 also had an error]
< [thread 1855841 also had an error]
< [0.081s][warning][os] Loading hsdis library failed
< [thread 1855810 also had an error]
< [thread 1855820 also had an error]
< #
< # If you would like to submit a bug report, please visit:
< #   https:;;bugreport.java.com;bugreport;crash.jsp
< #

…subsequently segmentation faults due to counter addressing
@Smoofie
Copy link
Contributor Author

Smoofie commented Feb 1, 2024

@gunnarmorling Thank you for the feedback! I've solved the seg fault issue and pushed the new version

@gunnarmorling
Copy link
Owner

Looking good now: 00:07.948. Also passing for 10K keys.

@gunnarmorling gunnarmorling merged commit a78c1fc into gunnarmorling:main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants