Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serkan-ozal's final submission #703

Conversation

serkan-ozal
Copy link
Contributor

@serkan-ozal serkan-ozal commented Jan 31, 2024

  • start worker threads in advance
  • increase region count

NOTE: This challenge closes for submissions on Jan 31 23:59:59 UTC. No new pull requests for adding submissions will be accepted after that time.
Any pending pull requests will be reviewed over the next few days, as described here.
The final leader board will be published by Feb 5.

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
  • Execution time: 2.6s/2.7s (It was 2.7s in the 7th submission in my testing env)
  • Execution time of reference implementation: 5m 54.1s

Let's see how much it will cut on the eval machine, finger crossed 🤞

- start worker thread in advance
- increase region count
@gunnarmorling
Copy link
Owner

It comes in slower than what's currently on main:

Benchmark 1: timeout -v 300 ./calculate_average_serkan-ozal.sh 2>&1
  Time (mean ± σ):      1.972 s ±  0.042 s    [User: 0.003 s, System: 0.005 s]
  Range (min … max):    1.919 s …  2.045 s    10 runs

Summary
  serkan-ozal: trimmed mean 1.9699492302850001, raw times 2.02893148966,1.93684216266,1.9580390516600001,1.9425117786600001,2.00418494666,1.95651161966,1.98900753166,1.91903356566,2.04456289566,1.9435652616599999

Leaderboard
grep: ./src/main/java*/dev/morling/onebrc/CalculateAverage_serkan-ozal.java: No such file or directory

| # | Result (m:s.ms) | Implementation     | JDK | Submitter     | Notes     |
|---|-----------------|--------------------|-----|---------------|-----------|
|   | 00:01.969 | [link](https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_serkan-ozal.java)| 21.0.1-open | [Serkan ÖZAL](https://github.com/serkan-ozal) |  |

In that light, and as we're after the cut-off time, I am going to close this one without merging. Thanks a lot for participating, @serkan-ozal! Your implementation is one of the top ones and it is the fastest JVM-based one. Congrats!

@gunnarmorling
Copy link
Owner

Hey @serkan-ozal!

Congrats again on being in the Top 20 of the One Billion Row Challenge!

To celebrate this amazing achievement, I would like to send you a 1BRC t-shirt and coffee mug. To claim your prize, fill out this form by Feb 18. After submitting the form, please provide a comment with the random value you've specified in the form, so that I know it is you who submitted it.

All data entered will solely be used in relation to processing this shipment. Shipments can be sent to any country listed here or here (I'll use whichever one is cheaper for me to ship to your location). A big thank you to Decodable for sponsoring these prizes!

Thanks a lot for participating in 1BRC,

--Gunnar

@serkan-ozal
Copy link
Contributor Author

Hey @gunnarmorling,

Thanks for organizing such a great challenge. Looking forward to next one :)

Here is my random value: 23369 15521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants