Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalculateAverage_gonix update #706

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

gonix
Copy link
Contributor

@gonix gonix commented Jan 31, 2024

Backported some of the optimizations from unsafe solution, ~20% improvement.

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
    • Comparing keys in lines: 331, 339, 348-360.
  • Execution time: ~1.4s
  • Execution time of reference implementation: ~145s
  • Machine: Intel i7-11800H @ 2.30GHz (max 4.6GHz), 8 cores (16 threads), 32GB RAM

Backported some of the optimizations from unsafe solution.
@gunnarmorling
Copy link
Owner

00:02.997 now. Thx for participating in 1BRC and creating one of the top entries!

@gunnarmorling gunnarmorling merged commit 1e7314d into gunnarmorling:main Feb 1, 2024
1 check passed
@gonix
Copy link
Contributor Author

gonix commented Feb 1, 2024

@gunnarmorling Thank you for the challenge!

@gunnarmorling
Copy link
Owner

Hey @gonix!

Congrats again on being in the Top 20 of the One Billion Row Challenge!

To celebrate this amazing achievement, I would like to send you a 1BRC t-shirt and coffee mug. To claim your prize, fill out this form by Feb 18. After submitting the form, please provide a comment with the random value you've specified in the form, so that I know it is you who submitted it.

All data entered will solely be used in relation to processing this shipment. Shipments can be sent to any country listed here or here (I'll use whichever one is cheaper for me to ship to your location). A big thank you to Decodable for sponsoring these prizes!

Thanks a lot for participating in 1BRC,

--Gunnar

@gonix
Copy link
Contributor Author

gonix commented Feb 12, 2024

Hey @gunnarmorling! Thanks again, I wasn't expecting prizes.
Random value: 5703 16776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants