Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update presetNormalizedInfo parameters of PresetTransformationType #408

Closed
wants to merge 3 commits into from

Conversation

guoyingtao
Copy link
Owner

update getTransformInfo(byNormalizedInfo:) to getTransformInfo(byNormalizedInfo: imageRotationType:) in CropViewProtocol

This PR has to do with #407

update getTransformInfo(byNormalizedInfo:) to getTransformInfo(byNormalizedInfo: imageRotationType:) in CropViewProtocol
@rahul6350
Copy link

rahul6350 commented Jul 31, 2024

Hey @guoyingtao rotation not working in this flow without rotation working fine but in rotation suppose i rotate one time in clockwise direction so roationType is counterclockwise270 but after transform and paasing this roationtype in edit it will rotate to 180 same when 180 rotation it will roate to .none angle is not correct[I think zoom is not working or scale when cropping with zoom to pa particular limit or extent then save and edit it will not zoom to that instant on paasing cropprops or on cropping suppose zoom and after edit not zooming to that instant because of that extra spacr shows which is not correct same exact image is shown when zooming i think scale is not calculated, but in presentinfo correct zoom on edit on this transformation to the same extent]

@guoyingtao
Copy link
Owner Author

@rahul6350 I close this PR for now. You can reopen it if needed.

@guoyingtao guoyingtao closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants