Use repository API for merges when possible #585
Conversation
|
OK, it works but it includes the |
|
that does not need work, that is just ok, if user decided to merge it via the cloud is what it is supposed to say. It is ok right? This of course does not meant that this PR has been reviewed just in case. But it is starting to look better |
|
It is fixable using the You can merge this as-is now, so that I can fix the merge message tomorrow 👍 (need to figure out how to pass extra headers to the client). |
|
polaris-preview is not going to work, the Knp GitHub library doesn't support the |
|
@sstok please rebase PR |
| return false; | ||
| } | ||
|
|
||
| if ($input->getOption('squash') || |
There was a problem hiding this comment.
You can still squash commits using the preview github API.
There was a problem hiding this comment.
True, but that will complicate the Adapter API 😄
There was a problem hiding this comment.
Not too much though. Probably worth it.
There was a problem hiding this comment.
Any suggestions? You need to detect whether the Adapter support this operation.
But I don't like adding yet another interface like CanSquashPullRequestOnMerge 💀
Adding an extra arguments on the method is no problem btw 👍
This speeds-up the merge process but still ensures additional options are possible.
Work in progress, needs testing