Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with latest version of Baysor #126

Closed
wants to merge 0 commits into from

Conversation

lguerard
Copy link
Contributor

Latest version of Baysor outputs either segmentation_polygons2D.json or segmentation_polygons3D.json depending on input data. This very basic fix would reestablish compatibility, in case users aren't running both 2D and 3D and outputting results in same folder

@lguerard
Copy link
Contributor Author

Actually, there's way more changes inside the Json output. The format completely changed, another option is needed to be passed to Baysor. I'll try it and come back here if I manage to have some fix(es).

@quentinblampey
Copy link
Collaborator

Thanks for diving into this! Let me know if you need some help
It indeed seems that there are several issues with the new Baysor version...

@lguerard
Copy link
Contributor Author

I'm having an issue but I don't know if that's on sopa's side or Baysor :

https://github.com/lguerard/sopa/blob/938b7dbf82666c5a5025f7e901a7feca2640fdb7/sopa/segmentation/transcripts.py#L127

gives an error because the loom files contains cells that aren't in the JSON. Do you know why that would be ?

@quentinblampey
Copy link
Collaborator

Sorry @lguerard I don't know what happened, it automatically closed the PR when I wanted to push some stuff to your PR
For some reasons I couldn't push, even though being up to date with your changes

@quentinblampey
Copy link
Collaborator

I'm going to create a new PR with your changes

@lguerard
Copy link
Contributor Author

No worries at all, but it might not yet be fully working, it's quite WIP at the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants