Use GuzzleHttp build_query instead of http_build_query when creating the baseString #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Feb 7, 2021
| @@ -203,7 +203,7 @@ protected function createBaseString(RequestInterface $request, array $params) | |||
| { | |||
| // Remove query params from URL. Ref: Spec: 9.1.2. | |||
| $url = $request->getUri()->withQuery(''); | |||
| $query = http_build_query($params, '', '&', PHP_QUERY_RFC3986); | |||
| $query = \GuzzleHttp\Psr7\build_query($params, PHP_QUERY_RFC3986); | |||
There was a problem hiding this comment.
This function is now deprecated.
There was a problem hiding this comment.
@GrahamCampbell, the funtion is deprecrated in Guzzle Guzzle PSR 7.2, however this package is still supporting Guzzle 6.x. Also, the issue is not fixed by closing. In case this package would only support Guzzle PSR 7.2, I can provide a patch using the new Query::build() method.
|
Stale. |
|
Since this was closed without a fix, I've documented a workaround for anyone else who runs into this here: #69 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a request which uses a query containing duplicate parameter keys, the signature is incorrectly generated.
eg. ?parameter=myvalue¶mter=myvalue2
This is being caused by the usage of "http_build_query" instead of the Guzzle "build_query" function in "createBaseString".
Closes #69.