Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GuzzleHttp build_query instead of http_build_query when creating the baseString #70

Closed
wants to merge 1 commit into from
Closed

Use GuzzleHttp build_query instead of http_build_query when creating the baseString #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Oauth1.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ protected function createBaseString(RequestInterface $request, array $params)
{
// Remove query params from URL. Ref: Spec: 9.1.2.
$url = $request->getUri()->withQuery('');
$query = http_build_query($params, '', '&', PHP_QUERY_RFC3986);
$query = \GuzzleHttp\Psr7\build_query($params, PHP_QUERY_RFC3986);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is now deprecated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell, the funtion is deprecrated in Guzzle Guzzle PSR 7.2, however this package is still supporting Guzzle 6.x. Also, the issue is not fixed by closing. In case this package would only support Guzzle PSR 7.2, I can provide a patch using the new Query::build() method.


return strtoupper($request->getMethod())
. '&' . rawurlencode($url)
Expand Down