Skip to content

Commit

Permalink
Merge pull request #56 from guzzle/improve_package
Browse files Browse the repository at this point in the history
Improve package
  • Loading branch information
sagikazarmark committed Dec 20, 2016
2 parents d5b0c65 + e278912 commit a59da6c
Show file tree
Hide file tree
Showing 6 changed files with 67 additions and 32 deletions.
9 changes: 9 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 4
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
7 changes: 7 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.editorconfig export-ignore
.gitattributes export-ignore
/.github/ export-ignore
.gitignore export-ignore
/.travis.yml export-ignore
/phpunit.xml.dist export-ignore
/tests/ export-ignore
43 changes: 30 additions & 13 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,37 @@
language: php

php:
- 5.5
- 5.6
- 7.0
- 7.1
- hhvm

sudo: false

install:
- travis_retry composer install --no-interaction --prefer-source
cache:
directories:
- $HOME/.composer/cache/files

php:
- 5.5
- 5.6
- 7.0
- 7.1
- hhvm

script: make test
env:
global:
- TEST_COMMAND="composer test"

matrix:
allow_failures:
- php: hhvm
fast_finish: true
allow_failures:
- php: hhvm
fast_finish: true
include:
- php: 5.5
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" COVERAGE=true TEST_COMMAND="composer test-ci"

before_install:
- if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi

install:
# To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
- if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then travis_retry composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
- travis_retry composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction

script:
- $TEST_COMMAND
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2015 Michael Dowling, https://github.com/mtdowling <[email protected]>
Copyright (c) 2015-2016 Michael Dowling, https://github.com/mtdowling <[email protected]>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
9 changes: 6 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"name": "guzzlehttp/promises",
"type": "library",
"description": "Guzzle promises library",
"keywords": ["promise"],
"license": "MIT",
Expand All @@ -15,17 +14,21 @@
"php": ">=5.5.0"
},
"require-dev": {
"phpunit/phpunit": "~4.0"
"phpunit/phpunit": "^4.0"
},
"autoload": {
"psr-4": {
"GuzzleHttp\\Promise\\": "src/"
},
"files": ["src/functions_include.php"]
},
"scripts": {
"test": "vendor/bin/phpunit",
"test-ci": "vendor/bin/phpunit --coverage-text"
},
"extra": {
"branch-alias": {
"dev-master": "1.0-dev"
"dev-master": "1.4-dev"
}
}
}
29 changes: 14 additions & 15 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit bootstrap="./tests/bootstrap.php"
colors="true">
<testsuites>
<testsuite>
<directory>tests</directory>
</testsuite>
</testsuites>
<filter>
<whitelist>
<directory suffix=".php">src</directory>
<exclude>
<directory suffix="Interface.php">src/</directory>
</exclude>
</whitelist>
</filter>
<phpunit colors="true" bootstrap="tests/bootstrap.php">
<testsuites>
<testsuite name="GuzzleHttp Promise Test Suite">
<directory>tests/</directory>
</testsuite>
</testsuites>
<filter>
<whitelist>
<directory suffix=".php">src/</directory>
<exclude>
<directory suffix="Interface.php">src/</directory>
</exclude>
</whitelist>
</filter>
</phpunit>

6 comments on commit a59da6c

@szepeviktor
Copy link

@szepeviktor szepeviktor commented on a59da6c Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagikazarmark Could it be that a v sneaked into the tag name?
https://github.com/guzzle/promises/tree/v1.3.1

@sagikazarmark
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, as I usually include it in the version tag, but it doesn't really matter as composer understands it. Note to self: pay attention in the future.

@szepeviktor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pay attention in the future

Thank you. A release checklist in the Wiki helps a lot.

@sagikazarmark
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: it mostly makes sense to indicate that a "tag"/"version" is actually a release. From a git ref and a packagist version point of view there is no difference between tags/dev branches, so the v prefix helps there to indicate a release. But consistency probably matters more in this case.

@szepeviktor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the v prefix helps there to indicate a release

I was diffing two composer.lock files and it poke my eyes.

@szepeviktor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amúgy egy HTTP üzemeltető ember (én) munkát keres
https://github.com/szepeviktor

Please sign in to comment.