Skip to content

Commit

Permalink
Support -strict in test arguments (#10039)
Browse files Browse the repository at this point in the history
We cannot yet enable this for all of GWT's own tests, see #10038 for
that followup. That said, that failure confirms that this feature is
working as expected.

Fixes #10037
  • Loading branch information
niloc132 authored Dec 17, 2024
1 parent 0286d6f commit 23e73f9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions user/src/com/google/gwt/junit/JUnitShell.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import com.google.gwt.dev.util.arg.ArgHandlerScriptStyle;
import com.google.gwt.dev.util.arg.ArgHandlerSetProperties;
import com.google.gwt.dev.util.arg.ArgHandlerSourceLevel;
import com.google.gwt.dev.util.arg.ArgHandlerStrict;
import com.google.gwt.dev.util.arg.ArgHandlerWarDir;
import com.google.gwt.dev.util.arg.ArgHandlerWorkDirOptional;
import com.google.gwt.junit.JUnitMessageQueue.ClientStatus;
Expand Down Expand Up @@ -299,6 +300,7 @@ public int handle(String[] args, int tagIndex) {
registerHandler(new ArgHandlerFilterJsInteropExports(options));
registerHandler(new ArgHandlerSetProperties(options));
registerHandler(new ArgHandlerClosureFormattedOutput(options));
registerHandler(new ArgHandlerStrict(options));

/*
* ----- Options specific to JUnitShell -----
Expand Down
2 changes: 1 addition & 1 deletion user/test/com/google/gwt/junit/JUnitShellTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void testDefaultModuleUrl() throws Exception {
public void testArgOptimize() throws Exception {
parseGoodArgs("-optimize", "8", "-XdisableInlineLiteralParameters",
"-XdisableRemoveDuplicateFunctions", "-XdisableClusterSimilarFunctions",
"-XdisableOrdinalizeEnums", "-XdisableOptimizeDataflow");
"-XdisableOrdinalizeEnums", "-XdisableOptimizeDataflow", "-strict");
}

private void parseGoodArgs(String... argsToUse) {
Expand Down

0 comments on commit 23e73f9

Please sign in to comment.