StackTraceDeobfuscator should never provide null methodName #9997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves accuracy of deobfuscated stack traces by using the best answer between original JS names, symbol maps, and source maps, by both avoiding taking an identifier from the sourcemap if none is provided, and normalizing away chromium specific prefixes in stack trace elements. Fixes gwtproject#9996 Follow-up gwtproject#9936
niloc132
commented
Aug 28, 2024
| */ | ||
| private static String normalizeSymbol(String symbol) { | ||
| // Chrome prefixes "new " for constructor calls, eliminate the prefix | ||
| if (symbol.startsWith("new ")) { |
There was a problem hiding this comment.
This could also be done in the client StackTraceCreator.ModernCollector, but it seemed lower impact to include it here instead.
|
Full CI build: https://github.com/niloc132/gwt/actions/runs/10600496224 |
jnehlmeier
reviewed
Aug 29, 2024
jnehlmeier
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves accuracy of deobfuscated stack traces by using the best answer between original JS names, symbol maps, and source maps, by both avoiding taking an identifier from the sourcemap if none is provided, and normalizing away chromium specific prefixes in stack trace elements.
Fixes #9996
Follow-up #9936