Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean formulas when processing askenet #184

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Clean formulas when processing askenet #184

merged 1 commit into from
Jun 25, 2023

Conversation

bgyori
Copy link
Member

@bgyori bgyori commented Jun 25, 2023

This PR handles lambda parameters appearing in rate laws from the shared representation. Fixes #183.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Merging #184 (00b9d03) into main (7d94ca2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   76.44%   76.45%           
=======================================
  Files          64       65    +1     
  Lines        4975     4977    +2     
=======================================
+ Hits         3803     3805    +2     
  Misses       1172     1172           
Impacted Files Coverage Δ
mira/sources/__init__.py 100.00% <100.00%> (ø)
mira/sources/askenet/petrinet.py 89.47% <100.00%> (+0.09%) ⬆️
mira/sources/sbml/processor.py 57.04% <100.00%> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bgyori bgyori merged commit 79a11a9 into main Jun 25, 2023
4 checks passed
@djinnome
Copy link

Thanks!

@bgyori bgyori deleted the formulas branch June 25, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template_model_from_askenet_json cannot read json from AskeNetPetriNetModel
3 participants