Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit normalization #194

Merged
merged 27 commits into from
Jul 11, 2023
Merged

Implement unit normalization #194

merged 27 commits into from
Jul 11, 2023

Conversation

bgyori
Copy link
Member

@bgyori bgyori commented Jul 9, 2023

This PR implements an approach to normalize any unit in a model that represents an absolute count of something (e.g., population).

todo

  • Add endpoint consuming mira template model
  • Add endpoint consuming AskePetriNet JSON

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Merging #194 (8c7bb65) into main (a499579) will increase coverage by 0.71%.
The diff coverage is 99.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   76.55%   77.27%   +0.71%     
==========================================
  Files          65       66       +1     
  Lines        5068     5228     +160     
==========================================
+ Hits         3880     4040     +160     
  Misses       1188     1188              
Impacted Files Coverage Δ
mira/metamodel/utils.py 91.66% <93.75%> (+4.16%) ⬆️
mira/metamodel/template_model.py 62.36% <94.73%> (+1.96%) ⬆️
mira/dkg/model.py 96.34% <100.00%> (+0.31%) ⬆️
mira/examples/sir.py 100.00% <100.00%> (ø)
mira/metamodel/__init__.py 100.00% <100.00%> (ø)
mira/metamodel/ops.py 79.88% <100.00%> (+3.65%) ⬆️
mira/metamodel/templates.py 85.18% <100.00%> (-0.39%) ⬇️
mira/metamodel/units.py 100.00% <100.00%> (ø)
mira/modeling/askenet/petrinet.py 96.31% <100.00%> (+0.61%) ⬆️
mira/sources/askenet/petrinet.py 91.30% <100.00%> (+0.07%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kkaris
Copy link
Contributor

kkaris commented Jul 11, 2023

🎉

@bgyori bgyori merged commit 56bf4c0 into main Jul 11, 2023
@bgyori bgyori deleted the unit_norm branch July 11, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants