Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement additional parameter logic for semantics reconstitution #210

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

bgyori
Copy link
Member

@bgyori bgyori commented Jul 14, 2023

This PR implements additional logic to #208 where parameters from both strata are combined in the final reconstituted model.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #210 (c4ae22a) into main (02fb6cd) will increase coverage by 0.03%.
The diff coverage is 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   77.85%   77.89%   +0.03%     
==========================================
  Files          68       68              
  Lines        5469     5482      +13     
==========================================
+ Hits         4258     4270      +12     
- Misses       1211     1212       +1     
Impacted Files Coverage Δ
mira/sources/askenet/flux_span.py 85.00% <92.30%> (+1.09%) ⬆️
tests/test_flux_span.py 100.00% <100.00%> (ø)
tests/test_model_api.py 96.80% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bgyori bgyori merged commit add147d into main Jul 14, 2023
@bgyori bgyori deleted the semantics branch July 14, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants