Created unit tests for all previously defined MIRA operations. Added new MIRA operations and most of their unit tests as well. Fixed several bugsa as well. #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New MIRA Operations in
mira/modeling/askenet/ops.py
replace_rate_law_mathml
add_parameter
remove_X
where X is an observable or parameteradd_transition
add_observable
replace_x_expression
Unit tests for MIRA operations in
tests/test_modeling/test_askenet.py
add_parameter
. Currently, the unit test foradd_transition
doesn't test for the presence of newly added states and parameters.Bug Fixes
Fixed a bug in commit
e9cb3dc
where changed parameters after callingreplace_parameter_id
were not showing in outputamr['semantics']['ode']['parameters']
Fixed a bug in commit
0ae9ed0
and commita1e6381
where observables in the output amr had identical values for theirname
andid
field (template model-> amr). Also fixed an issue where template models constructed from an amr file (amr -> template model) used aobservables['id']
for the name and display_name of a concept. Now thename
field will take the display_name attribute associated with a concept andid
will take the id attribute associated with a oncept.