Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grouped natural conversion class and test and schema #346

Closed
wants to merge 1 commit into from

Conversation

augeorge
Copy link
Contributor

added a class for GroupedNaturalConversion, a unit test, and an updated schema.

@augeorge
Copy link
Contributor Author

see issue #345

@bgyori
Copy link
Member

bgyori commented Jul 23, 2024

Thanks, this looks good! I am still thinking about the right name for this, "Grouped" might not be the best choice for what this is, I'll think about an alternative. We will also look at other places in the package where the new template type would have to be handled.

@augeorge
Copy link
Contributor Author

Thanks, this looks good! I am still thinking about the right name for this, "Grouped" might not be the best choice for what this is, I'll think about an alternative. We will also look at other places in the package where the new template type would have to be handled.

thanks, I think the sbml processor should be updated as well

@bgyori
Copy link
Member

bgyori commented Jul 28, 2024

Hi @augeorge, just an update: thanks for starting the implementation. I made some local changes to naming, etc. and we started on supporting the kind of metabolic model you are working with. This, however, requires overcoming multiple complications such as (1) handling some SBML corner cases related to species annotation (2) handling reversible reactions (3) mapping non-trivial stoichiometry to the template representation. We are making progress and will try to finish these new features as soon as possible.

@bgyori
Copy link
Member

bgyori commented Jul 30, 2024

It appears the box was not checked to allow maintainers to make changes to the PR so I will have to close this and open a new one with the new implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants