Only filter cities by minimum population #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #370 by only removing cities with population under the minimum threshold after their related first order adminsitrative divisions have been added when we get geoname terms. After using the
add_resourceendpoint and adding geoname terms to the dkg, we can confirm the precense of the missing geoname nodes mentioned in the linked issue. The new set of geoname terms is a superset of the old set and around 1,200 more geoname terms have been added.[ { "id": "geonames:4142224", "name": "Delaware", "type": "individual", "obsolete": false, "synonyms": [], "xrefs": [], "labels": [], "properties": { "code": [ "US.DE" ] } } ]{ "id": "geonames:5843591", "name": "Wyoming", "type": "individual", "obsolete": false, "synonyms": [], "xrefs": [], "labels": [], "properties": { "code": [ "US.WY" ] } } ][ { "id": "geonames:4971068", "name": "Maine", "type": "individual", "obsolete": false, "synonyms": [], "xrefs": [], "labels": [], "properties": { "code": [ "US.ME" ] } } ][ { "id": "geonames:4826850", "name": "West Virginia", "type": "individual", "obsolete": false, "synonyms": [], "xrefs": [], "labels": [], "properties": { "code": [ "US.WV" ] } } ][ { "id": "geonames:5242283", "name": "Vermont", "type": "individual", "obsolete": false, "synonyms": [], "xrefs": [], "labels": [], "properties": { "code": [ "US.VT" ] } } ]