Fix #229: Match Arduino flash layout #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
commented
Aug 6, 2023
| @@ -1,5 +1,6 @@ | |||
| on: | |||
| push: | |||
| pull_request: | |||
There was a problem hiding this comment.
Not strictly related to this PR but super nice to have. This way any PR will get a platform.io build you can use for testing.
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs this should align the flash layout to the Arduino IDE defaults:
I tested this and verified that upgrading a Wemos D1 Mini via the web UI works great under both possible conditions: